Vtctldserver backup #9062
Closed
Vtctldserver backup #9062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the original implementation, bidiStream used one channel, `errch`, to receive both mid-stream errors and "the stream is closed now" errors. This meant that, due to go's pseudo-random channel selection, if the stream was closed and there were still messages in the stream (so, both `ch` and `errch` were select-able), then there was a chance that an adapter's `Recv()` would return `io.EOF` even though there were still responses to pull off the stream. This version moves to a more context-cancel like paradigm, using a separate context to check if the stream is closed. Then, we adjust the template for `Recv` to select: 1. Is stream context done 2. Is streamclosed context done 4. Does mid-stream error channel have an error 3. Does message channel have a message And the template for `Send` to: 1. If streamclosed context done, return `errStreamClosed`; otherwise 2. Send to the message channel and return nil <hr/> Note that this commit also makes a more public/exported API for bidiStream, to set up a simpler (diff-wise) filemove in a later change. Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
vtctldserver-backup
branch
from
ae7382f
to
7d66feb
Compare
…vt/vtctl` Turns out this construct is useful for writing stream-based unit tests for `grpcvtctldserver`, and this lets us reuse this code there without exporting it completely. Signed-off-by: Andrew Mason <amason@slack-corp.com>
3 tasks
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
vtctldserver-backup
branch
from
7d66feb
to
b8c92e1
Compare
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Checklist
Deployment Notes